Re-Adding metrics level into the tests #975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
|
@jpkrohling, @pavolloffay, could you please take a look? |
pavolloffay
requested changes
Jul 13, 2022
| @@ -21,3 +21,6 @@ spec: | |||
| receivers: [otlp] | |||
| processors: [] | |||
| exporters: [logging] | |||
| telemetry: | |||
There was a problem hiding this comment.
what is the purpose of this change? It changes OTELcol's config that is used in the test. How is this change being asserted? Is this even needed for the auto-instrumentation (I would say it's not)?
There was a problem hiding this comment.
I've put back that configuration because we have removed it on the following PR: #680.
I agree that we should explore the test assertion and remove them from the auto-instrumentation.
There was a problem hiding this comment.
Agree, a short comment on why this is needed and where it's used would be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuri Sa yurimsa@gmail.com
Resolve #702